Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

chore: use switchboard as dependency for embedded sdk #18728

Merged
merged 1 commit into from
Feb 15, 2022
Merged

chore: use switchboard as dependency for embedded sdk #18728

merged 1 commit into from
Feb 15, 2022

Conversation

suddjian
Copy link
Member

SUMMARY

Just a follow up from #18652, adjusting some version numbers to actually include the dependency in the embedded sdk.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@suddjian suddjian requested a review from lilykuang February 15, 2022 03:21
@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #18728 (61c995e) into master (48a8095) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18728      +/-   ##
==========================================
- Coverage   66.32%   66.32%   -0.01%     
==========================================
  Files        1620     1620              
  Lines       63053    63060       +7     
  Branches     6365     6368       +3     
==========================================
+ Hits        41819    41823       +4     
- Misses      19575    19579       +4     
+ Partials     1659     1658       -1
Flag Coverage Δ
javascript 51.25% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/components/FilterableTable/FilterableTable.tsx 71.42% <0.00%> (-0.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48a8095...61c995e. Read the comment docs.

lilykuang
lilykuang approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@lilykuang lilykuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suddjian suddjian merged commit 97a879e into apache:master Feb 15, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lilykuang lilykuang lilykuang approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suddjian @lilykuang @mistercrunch